Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StackExchangeRedis instrumentation #3346

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 7, 2022

Towards #3317

StackExchangeRedis instrumentation has moved to contrib repo: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Instrumentation.StackExchangeRedis

Changes

  • Remove StackExchangeRedis instrumentation

@utpilla utpilla requested a review from a team as a code owner June 7, 2022 02:52
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #3346 (9861830) into main (8df82a2) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3346      +/-   ##
==========================================
+ Coverage   85.47%   85.62%   +0.15%     
==========================================
  Files         270      266       -4     
  Lines        9561     9370     -191     
==========================================
- Hits         8172     8023     -149     
+ Misses       1389     1347      -42     
Impacted Files Coverage Δ
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.20% <0.00%> (-3.30%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 73.72% <0.00%> (-0.85%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️

@cijothomas
Copy link
Member

Removed Redis tests (intergration) from main branch requirements. Good to merge.

@cijothomas cijothomas merged commit c90ab4a into open-telemetry:main Jun 7, 2022
@utpilla utpilla deleted the utpilla/Remove-StackExchangeRedis-Instrumentation branch November 3, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants