Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.OpenTelemetryProtocol] User agent changed to OTel-OTLP-Exporter-Dotnet/{NuGet Package Version} #5528

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Apr 10, 2024

Follow up to #5498

Changes

Handles following comments:

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team April 10, 2024 05:13
@Kielek
Copy link
Contributor Author

Kielek commented Apr 10, 2024

@CodeBlanch, @reyang, FYI

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (6250307) to head (b45be34).
Report is 175 commits behind head on main.

❗ Current head b45be34 differs from pull request most recent head d45c095. Consider uploading reports for the commit d45c095 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5528      +/-   ##
==========================================
+ Coverage   83.38%   85.52%   +2.13%     
==========================================
  Files         297      289       -8     
  Lines       12531    12579      +48     
==========================================
+ Hits        10449    10758     +309     
+ Misses       2082     1821     -261     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.09% <ø> (?)
unittests-Instrumentation-Stable 24.13% <ø> (?)
unittests-Solution-Experimental 85.52% <100.00%> (?)
unittests-Solution-Stable 85.48% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 99.08% <100.00%> (+2.71%) ⬆️
...ent/Implementation/GrpcClientDiagnosticListener.cs 76.19% <ø> (-2.39%) ⬇️
...qlClient/Implementation/SqlActivitySourceHelper.cs 100.00% <ø> (ø)
src/OpenTelemetry/Sdk.cs 100.00% <ø> (ø)

... and 65 files with indirect coverage changes

@Kielek Kielek changed the title [Exporter.OpenTelemetryProtocol] User agent changed to OTel-OTLP-Exporter-Dotnet-{NuGet Package Version} [Exporter.OpenTelemetryProtocol] User agent changed to OTel-OTLP-Exporter-Dotnet/{NuGet Package Version} Apr 10, 2024
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Apr 10, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 876e4fa into open-telemetry:main Apr 10, 2024
50 checks passed
@Kielek Kielek deleted the otlp-exporter-user-agent-withotu-commit-hash branch April 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants