-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Automatically add area labels when new issue is opened #5601
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5601 +/- ##
==========================================
+ Coverage 83.38% 85.52% +2.14%
==========================================
Files 297 253 -44
Lines 12531 10890 -1641
==========================================
- Hits 10449 9314 -1135
+ Misses 2082 1576 -506
Flags with carried forward coverage won't be shown. Click here to find out more. |
- name: Add labels for areas found in bug issue descriptions | ||
shell: pwsh | ||
run: | | ||
$match = [regex]::Match('${{ github.event.issue.body }}', '^[#]+ Area\s*?(area:\w+)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker here, I actually feel this makes it harder to maintain as it cannot easily run on local dev box, editor/IDE don't have good support (e.g. how to debug) (anyways, I'm not the one who will maintain it so feel free to treat it as my subjective opinion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you on this point! I'm going to circle back to this though. I'm sort of in the middle of improving the release process which is creating a lot of inline powershell scripts. Once that is stable I'll come back and see how it can all be cleaned up.
[Modified @reyang's submission on #5600 to use powershell.]
Original content:
It'll look like this
I also tweaked the wording of the issue template (the original wording was copied from other opentelemetry repositories).