Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Automatically add area labels when new issue is opened #5601

Merged
merged 4 commits into from
May 9, 2024

Conversation

CodeBlanch
Copy link
Member

[Modified @reyang's submission on #5600 to use powershell.]

Original content:

It'll look like this
image

I also tweaked the wording of the issue template (the original wording was copied from other opentelemetry repositories).

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label May 8, 2024
@CodeBlanch CodeBlanch requested a review from a team May 8, 2024 18:47
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (6250307) to head (8005e32).
Report is 213 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5601      +/-   ##
==========================================
+ Coverage   83.38%   85.52%   +2.14%     
==========================================
  Files         297      253      -44     
  Lines       12531    10890    -1641     
==========================================
- Hits        10449     9314    -1135     
+ Misses       2082     1576     -506     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.47% <ø> (?)
unittests-Solution-Stable 85.43% <ø> (?)
unittests-Unstable-Core 19.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 124 files with indirect coverage changes

- name: Add labels for areas found in bug issue descriptions
shell: pwsh
run: |
$match = [regex]::Match('${{ github.event.issue.body }}', '^[#]+ Area\s*?(area:\w+)')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker here, I actually feel this makes it harder to maintain as it cannot easily run on local dev box, editor/IDE don't have good support (e.g. how to debug) (anyways, I'm not the one who will maintain it so feel free to treat it as my subjective opinion)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you on this point! I'm going to circle back to this though. I'm sort of in the middle of improving the release process which is creating a lot of inline powershell scripts. Once that is stable I'll come back and see how it can all be cleaned up.

OpenTelemetry.sln Outdated Show resolved Hide resolved
@CodeBlanch CodeBlanch merged commit ee5e1e0 into open-telemetry:main May 9, 2024
43 checks passed
@CodeBlanch CodeBlanch deleted the repo-add-labels branch May 9, 2024 17:22
@CodeBlanch CodeBlanch mentioned this pull request May 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants