Apply suggestions from code review

open-telemetry · Dec 12, 2023 · 59ecc7a · 59ecc7a
1 parent fad7c17
commit 59ecc7a
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go b/instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go b/instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go b/instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go b/instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go b/instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go b/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go b/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",

diff --git a/internal/shared/semconvutil/httpconv.go.tmpl b/internal/shared/semconvutil/httpconv.go.tmpl
@@ -211,7 +211,7 @@ func (c *httpConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return attrs
 }
 
-// TraceClientRequest returns attributes for an HTTP request made by a client. The
+// ClientRequest returns attributes for an HTTP request made by a client. The
 // following attributes are always returned: "http.url", "http.method",
 // "net.peer.name". The following attributes are returned if the related values
 // are defined in req: "net.peer.port", "http.user_agent",