Skip to content

Commit

Permalink
lint corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
AkhigbeEromo committed Jun 18, 2024
1 parent 0ba4cbb commit d535bc1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions bridges/otelzerolog/hook.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ type config struct {
provider log.LoggerProvider
version string
schemaURL string

//Question: Do i need to define `levels []zerolog.Level`
}

func newConfig(options []Option) config {
Expand All @@ -56,8 +54,6 @@ func newConfig(options []Option) config {
if c.provider == nil {
c.provider = global.GetLoggerProvider()
}


return c
}

Expand Down Expand Up @@ -127,9 +123,10 @@ func NewSeverityHook(name string, options ...Option) *SeverityHook {
// OpenTelemetry. See package documentation for how conversions are made.
type SeverityHook struct {
logger log.Logger
level zerolog.Level
level zerolog.Level
}

// Level returns the log level configured for the SeverityHook.
func (h *SeverityHook) Level() zerolog.Level {
return h.level
}
}
2 changes: 1 addition & 1 deletion bridges/otelzerolog/hook_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ func TestNewSeverityHook(t *testing.T) {
})
}
}

func TestSeverityHook_Levels(t *testing.T) {
hook := &SeverityHook{
level: zerolog.DebugLevel,
}

assert.Equal(t, zerolog.DebugLevel, hook.Level())
}

0 comments on commit d535bc1

Please sign in to comment.