Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back metric integration testing to the otelgocql/test package #2761

Closed
MrAlias opened this issue Sep 16, 2022 · 2 comments · Fixed by #2962
Closed

Add back metric integration testing to the otelgocql/test package #2761

MrAlias opened this issue Sep 16, 2022 · 2 comments · Fixed by #2962
Assignees
@MrAlias
Labels
instrumentation: otelgocql

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 16, 2022 •
edited
Loading

Metric integration testing for the otelgocql instrumentation was removed in #2760
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Sep 16, 2022
@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 28, 2022
This was referenced Oct 28, 2022
Closed
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 28, 2022

Blocked by open-telemetry/opentelemetry-go#3407

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 31, 2022

Unblocked. Use a manual-reader to collect expected metrics and the metricdatatest package to compare expected values (or just compare directly).

@MrAlias MrAlias self-assigned this Nov 1, 2022
@MrAlias MrAlias mentioned this issue Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
instrumentation: otelgocql
Projects
No open projects
Go: Metric SDK (Beta)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back metric integration testing to the otelgocql/test package MrAlias/opentelemetry-go-contrib
1 participant
@MrAlias