Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Preparation: Update metric SDK use in otelgocql #2760

Merged
merged 4 commits into from
Sep 17, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 16, 2022

Temporarily remove the metric SDK in otelgocql/test use while the metrictest package is being developed.

Update the example package in otelgocql to use the new metric SDK.

Part of open-telemetry/opentelemetry-go#3176

Temporarily remove the metric SDK use while the metrictest package is
being developed.
@MrAlias MrAlias added this to the v0.36.0 -- Metric Alpha SDK milestone Sep 16, 2022
@MrAlias MrAlias changed the title Release Preparation: Remove metric SDK use in otelgocql/test Release Preparation: Update metric SDK use in otelgocql Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #2760 (1a63aa4) into main (c4876c3) will increase coverage by 2.9%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2760     +/-   ##
=======================================
+ Coverage   74.4%   77.4%   +2.9%     
=======================================
  Files        145     147      +2     
  Lines       6707    6753     +46     
=======================================
+ Hits        4993    5229    +236     
+ Misses      1566    1363    -203     
- Partials     148     161     +13     
Impacted Files Coverage Δ
.../github.com/gocql/gocql/otelgocql/internal/cass.go 95.1% <0.0%> (ø)
...n/github.com/gocql/gocql/otelgocql/test/version.go 0.0% <0.0%> (ø)
...ntation/github.com/gocql/gocql/otelgocql/config.go 57.1% <0.0%> (+57.1%) ⬆️
...ion/github.com/gocql/gocql/otelgocql/instrument.go 62.5% <0.0%> (+62.5%) ⬆️
...ation/github.com/gocql/gocql/otelgocql/observer.go 75.1% <0.0%> (+75.1%) ⬆️
...entation/github.com/gocql/gocql/otelgocql/gocql.go 100.0% <0.0%> (+100.0%) ⬆️
...tation/github.com/gocql/gocql/otelgocql/version.go 100.0% <0.0%> (+100.0%) ⬆️

@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 16, 2022
@MrAlias

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants