Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud.provider and cloud.platform to AWS detectors #1043

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #1043 (92cf95a) into main (265ebea) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1043   +/-   ##
=====================================
  Coverage   69.4%   69.4%           
=====================================
  Files         77      77           
  Lines       4929    4935    +6     
=====================================
+ Hits        3423    3429    +6     
  Misses      1367    1367           
  Partials     139     139           
Impacted Files Coverage Δ
detectors/aws/ec2/ec2.go 85.7% <100.0%> (+0.2%) ⬆️
detectors/aws/ecs/ecs.go 54.7% <100.0%> (+2.2%) ⬆️
detectors/aws/eks/detector.go 35.6% <100.0%> (+2.2%) ⬆️

@Aneurysm9 Aneurysm9 merged commit 2c59f62 into open-telemetry:main Sep 3, 2021
@abihf abihf deleted the ecs-eks-cloud-platform branch September 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants