Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithTracerProvider() func to httptrace package #1128

Merged

Conversation

erichsueh3
Copy link
Contributor

Description:
This PR adds the WithTracerProvider() function to the httptrace package. This is done in clienttrace.go.

Link to tracking Issue:
#1105

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #1128 (2aee336) into main (1412a89) will decrease coverage by 0.0%.
The diff coverage is 44.4%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1128     +/-   ##
=======================================
- Coverage   68.2%   68.2%   -0.1%     
=======================================
  Files        119     119             
  Lines       5205    5211      +6     
=======================================
+ Hits        3555    3556      +1     
- Misses      1511    1516      +5     
  Partials     139     139             
Impacted Files Coverage Δ
...on/net/http/httptrace/otelhttptrace/clienttrace.go 76.0% <44.4%> (-1.6%) ⬇️

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be good to update CHANGELOG.md

@erichsueh3
Copy link
Contributor Author

Would a test for the WithTracerProvider() function be necessary? Not sure how much value it adds due to the simplicity of the function.

Asked this on the linked issue, but reposting here for more visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants