Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emicklei/go-restful instrumentation #115

Merged
merged 8 commits into from
Jul 1, 2020

Conversation

evantorrie
Copy link
Contributor

fixes #79

A filter may be added at any one of the following:

  • container scope
  • webservice scope
  • route scope

Includes a docker-compose example with instructions.

A filter may be added at any one of the following:
   * container scope
   * webservice scope
   * route scope

Includes a docker-compose example with instructions.
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, nothing blocking.

Did we want to move this to github.com/emicklei/go-restful? I know we had talked about this for the other instrumentation that is missing it as well. Maybe a subsequent PR to move everything?

instrumentation/emicklei/go-restful/example/server.go Outdated Show resolved Hide resolved
instrumentation/emicklei/go-restful/restful.go Outdated Show resolved Hide resolved
@evantorrie
Copy link
Contributor Author

Did we want to move this to github.com/emicklei/go-restful? I know we had talked about this for the other instrumentation that is missing it as well. Maybe a subsequent PR to move everything?

Yes, I planned a subsequent PR to move everything from github.com under a github.com directory.

@MrAlias MrAlias merged commit a24a7d5 into open-telemetry:master Jul 1, 2020
@evantorrie evantorrie deleted the go-restful branch July 1, 2020 17:57
@MrAlias MrAlias mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instrumentation for go-restful
3 participants