Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all github.com instrumentation plugins down one level in directory hierarchy #118

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Move all github.com instrumentation plugins down one level in directory hierarchy #118

merged 3 commits into from
Jul 1, 2020

Conversation

evantorrie
Copy link
Contributor

For

  1. consistency with other plugins placed under the instrumentation/ directory
  2. consistency with the documentation

this moves all instrumentation plugins for github.com/ packages underneath a instrumentation/github.com/ directory.

In addition, also added a doc.go for labstack/echo. It was previously missing one.

MrAlias
MrAlias approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit 370078e into open-telemetry:master Jul 1, 2020
@evantorrie evantorrie deleted the github-down branch July 4, 2020 20:18
@lizthegrey
Copy link
Member

This needed to also change .github/dependabot.yml

@lizthegrey lizthegrey mentioned this pull request Jul 10, 2020
Closed
@MrAlias MrAlias mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evantorrie @lizthegrey @Aneurysm9 @MrAlias