Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation for Kafka #134

Merged
merged 20 commits into from
Jul 23, 2020
Merged

Add instrumentation for Kafka #134

merged 20 commits into from
Jul 23, 2020

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Jul 13, 2020 •
edited
Loading

Split from #87

code complete with tests passing
documentation updated

@XSAM XSAM force-pushed the feature/kafka-instrumentation branch from fe7dc44 to 06462e5 Compare July 13, 2020 08:42
lizthegrey
lizthegrey reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@lizthegrey lizthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this porting work! Do we have benchmarks for the overhead of this integration?

@XSAM
Copy link
Member Author

XSAM commented Jul 14, 2020

@lizthegrey I can write benchmarks for this integration based on mock sarama and tracer.

@XSAM XSAM force-pushed the feature/kafka-instrumentation branch 2 times, most recently from 0cd9c55 to 4fd08b6 Compare July 17, 2020 10:32
@XSAM XSAM force-pushed the feature/kafka-instrumentation branch from 4fd08b6 to 253bc31 Compare July 17, 2020 10:33
MrAlias
MrAlias reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't made it all the way through this yet (sorry 😞 ), but from what I have made it through it looks good in general. This is a partial review, but I plan to take another go at reviewing this later today.

instrumentation/github.com/Shopify/sarama/go.mod Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/consumer.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/consumer_test.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/consumer_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias linked an issue Jul 20, 2020 that may be closed by this pull request
Add instrumentation for Kafka: github.com/Shopify/sarama #87
Closed
4 tasks
MrAlias
MrAlias approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for digging into this!

All comments are for minor questions/asks. Nothing blocking that couldn't be addressed in a follow on PR.

instrumentation/github.com/Shopify/sarama/go.mod Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/producer.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/consumer_test.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/message_test.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/option.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/producer.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/producer.go Outdated Show resolved Hide resolved
instrumentation/github.com/Shopify/sarama/producer_test.go Outdated Show resolved Hide resolved
lizthegrey
lizthegrey reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@lizthegrey lizthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add line to .github/dependabot.yml as well to automatically update dependencies here.

once @MrAlias's comments are addressed I'm an approve. thanks for the hard work on this!

@XSAM XSAM force-pushed the feature/kafka-instrumentation branch from 4f51c3a to 66e8ef5 Compare July 23, 2020 03:24
@XSAM XSAM force-pushed the feature/kafka-instrumentation branch from 66e8ef5 to 7c24dde Compare July 23, 2020 03:28
@lizthegrey
Copy link
Member

Thanks for all the hard work!

@lizthegrey lizthegrey merged commit 70957fc into open-telemetry:master Jul 23, 2020
@XSAM XSAM deleted the feature/kafka-instrumentation branch July 23, 2020 05:50
@MrAlias MrAlias mentioned this pull request Jul 31, 2020
Merged
@XSAM XSAM mentioned this pull request Aug 1, 2020
Closed
6 tasks
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Aug 28, 2020
@MrAlias
Add @XSAM as project approver
8e7f58d 
[Requirements](https://github.com/open-telemetry/community/blob/master/community-membership.md#requirements-2)
- [X] >=10 substantive contributions (open-telemetry/opentelemetry-go-contrib#134, open-telemetry/opentelemetry-go-contrib#153, open-telemetry/opentelemetry-go-contrib#221, open-telemetry/opentelemetry-go-contrib#298, open-telemetry/opentelemetry-go-contrib#303, open-telemetry#796, open-telemetry#905, open-telemetry#986, open-telemetry#1044, open-telemetry#1031, open-telemetry#1102)
- [X] Active >1mo
- [X] add to CODEOWNERS  (done in this pull)
- [X] Add to CONTRIBUTING.md (done in this pull)
- [X] Maintainer nomination: @MrAlias
- [ ] Other maintainer(s) (@Aneurysm9) sign-off
- [ ]  Add to @open-telemetry/go-approvers
This was referenced Aug 28, 2020
Merged
Merged
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@rghetia
Add stdout trace exporter (#153)
fa7d053 
* Add stdout trace exporter (#134)

* Update go.mod and go.sum

* Do not use assert in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@MrAlias MrAlias MrAlias approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add instrumentation for Kafka: github.com/Shopify/sarama
4 participants
@XSAM @lizthegrey @Aneurysm9 @MrAlias