Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic conventions to v1.7.0 #1385

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

Aneurysm9
Copy link
Member

Fixes #1384

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1385 (757b149) into main (e81f85a) will increase coverage by 6.4%.
The diff coverage is n/a.

❗ Current head 757b149 differs from pull request most recent head b021bd4. Consider uploading reports for the commit b021bd4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1385     +/-   ##
=======================================
+ Coverage   69.3%   75.7%   +6.4%     
=======================================
  Files        127     132      +5     
  Lines       5496    5561     +65     
=======================================
+ Hits        3810    4215    +405     
+ Misses      1538    1182    -356     
- Partials     148     164     +16     
Impacted Files Coverage Δ
detectors/aws/ec2/ec2.go 89.0% <ø> (ø)
detectors/aws/ecs/ecs.go 54.7% <ø> (ø)
detectors/aws/eks/detector.go 35.6% <ø> (ø)
detectors/aws/lambda/detector.go 90.0% <ø> (ø)
detectors/gcp/cloud-run.go 100.0% <ø> (ø)
detectors/gcp/gce.go 8.7% <ø> (ø)
detectors/gcp/gke.go 0.0% <ø> (ø)
...github.com/Shopify/sarama/otelsarama/dispatcher.go 100.0% <ø> (ø)
...n/github.com/Shopify/sarama/otelsarama/producer.go 94.7% <ø> (ø)
.../github.com/aws/aws-lambda-go/otellambda/lambda.go 88.6% <ø> (ø)
... and 30 more

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9
Copy link
Member Author

Merging <24h with a single approval as this is a mechanical change to import paths that fixes issues experienced by users.

@Aneurysm9 Aneurysm9 merged commit 6c86403 into open-telemetry:main Nov 2, 2021
@Aneurysm9 Aneurysm9 deleted the semconv_update branch November 2, 2021 18:27
@odsod
Copy link

odsod commented Nov 4, 2021

@MrAlias @Aneurysm9 Thanks for the quick fix! Would you be open to cut a patch release for this?

odsod added a commit to einride/cloudrunner-go that referenced this pull request Nov 5, 2021
The following patch has been merged upstream in OpenTelemetry, which
fixes the resource detection issue stemming from a transitive dependency
on an incompatible version of the OpenTelemetry semantic conventions
module:

open-telemetry/opentelemetry-go-contrib#1385
odsod added a commit to einride/cloudrunner-go that referenced this pull request Nov 5, 2021
The following patch has been merged upstream in OpenTelemetry, which
fixes the resource detection issue stemming from a transitive dependency
on an incompatible version of the OpenTelemetry semantic conventions
module:

open-telemetry/opentelemetry-go-contrib#1385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot merge resource due to conflicting Schema URL in OTEL v1.1.0 / OTEL-contrib v1.1.0
3 participants