Modified otel-http-server-duration from microseconds to milliseconds #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rltoSD
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Aneurysm9
approved these changes
Dec 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #1537 +/- ##
=====================================
Coverage 69.3% 69.3%
=====================================
Files 127 127
Lines 5479 5480 +1
=====================================
+ Hits 3799 3800 +1
Misses 1533 1533
Partials 147 147
|
MrAlias
reviewed
Dec 22, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
reviewed
Dec 23, 2021
dashpole
approved these changes
Jan 4, 2022
MrAlias
approved these changes
Jan 4, 2022
This was referenced Feb 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is to modify otel http server duration from microseconds to milliseconds as per the specs mentioned in OpenTelemetry Go.
Link to tracking Issue:
issue #1335