Extract region name from Cloud Run metadata server response #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was returning a full string like /projects/123/regions/r, which does not match up with what the semvconv.CloudRegionKey value is supposed to be.
nikklassen
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
|
Aneurysm9
approved these changes
Dec 27, 2021
XSAM
approved these changes
Dec 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #1546 +/- ##
=====================================
Coverage 69.3% 69.3%
=====================================
Files 127 127
Lines 5480 5486 +6
=====================================
+ Hits 3800 3806 +6
Misses 1533 1533
Partials 147 147
|
MrAlias
approved these changes
Jan 4, 2022
Merged
MrAlias
added a commit
that referenced
this pull request
Feb 14, 2022
* Update versions.yaml * Deprecate the datadog exporter * Remove hist/exact support from dogstatsd exporter * Update otel dependencies * Update changelog * Prepare stable-v1 for version v1.4.0 * Prepare experimental-instrumentation for version v0.29.0 * Prepare experimental-metrics for version v0.29.0 * Prepare experimental-metric-exporters for version v0.29.0 * Update cortex exporter pkg imports * Update datadog exporter example to not self import This is now a deprecated package, do not depend on it. * go mod tidy cortex exporter * Update datadog deps * Remove points agg from datadog * Fix deprecated dep in dogstatsd * Remove deprecated dep in otelgocql example * Deprecate the cortex exporter * Deprecate the dogstatsd exporter * Fix lint Do not fail lint for importing deprecated packages from inside those deprecated packages. * Update CHANGELOG.md * Add fix from #1546 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was returning a full string like /projects/123/regions/r, which does not match up with what the semvconv.CloudRegionKey value is supposed to be.
Originally filed as GoogleCloudPlatform/opentelemetry-operations-go#227