Remove the MinMaxSumCount from cortex and datadog exporter #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyuancheung
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1554 +/- ##
=======================================
- Coverage 69.3% 69.3% -0.1%
=======================================
Files 127 127
Lines 5486 5424 -62
=======================================
- Hits 3806 3760 -46
+ Misses 1533 1521 -12
+ Partials 147 143 -4
|
dashpole
reviewed
Jan 6, 2022
dashpole
approved these changes
Jan 6, 2022
hanyuancheung
force-pushed
the
remove-MinMaxSumCount-from-cortex
branch
from
9319b18
to
1c6bc3e
Compare
5 tasks
Aneurysm9
approved these changes
Jan 6, 2022
hanyuancheung
changed the title
All done. PTAL @Aneurysm9 @dashpole |
jmacd
approved these changes
Jan 7, 2022
hanyuancheung
force-pushed
the
remove-MinMaxSumCount-from-cortex
branch
from
360222a
to
7c80254
Compare
hanyuancheung
force-pushed
the
remove-MinMaxSumCount-from-cortex
branch
from
7c80254
to
ba223ad
Compare
hanyuancheung
force-pushed
the
remove-MinMaxSumCount-from-cortex
branch
from
3b4d329
to
e0238ca
Compare
|
Thanks for the suggestions, PTAL. |
5 tasks
6 tasks
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the #1478 todo list: