-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented logic for Opentracing baggage propagation #1880
Implemented logic for Opentracing baggage propagation #1880
Conversation
Pending CLA authorization from Lightstep right now. |
Codecov Report
@@ Coverage Diff @@
## main #1880 +/- ##
=======================================
+ Coverage 70.5% 70.6% +0.1%
=======================================
Files 129 129
Lines 5564 5587 +23
=======================================
+ Hits 3925 3948 +23
Misses 1500 1500
Partials 139 139
|
Looks great, thanks! |
@carlosalberto one result of this behavior is that if baggage from the opentracing side is invalid, we don't create a context from remote span. Should we instead change this block to be something like: bags, err := extractBags(carrier)
if err != nil {
return trace.ContextWithRemoteSpanContext(ctx, sc)
}
ctx = baggage.ContextWithBaggage(ctx, bags)
return trace.ContextWithRemoteSpanContext(ctx, sc) |
@jaronoff97 Oh, good call - indeed, invalid |
…pentelemetry-go-contrib into jaronoff97/ot-baggage-props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
What
This PR implements the logic for extracting baggage in the opentracing propagator.
Why
Users of the opentracing baggage propagator want to extract baggage so that they can effectively migrate from opentracing to opentelemetry.
Other Implementations:
Java
Python
Javascript