Move gRPC instrumentation from go.opentelemetry.io/otel #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the existing grpctrace package from the go.opentelemetry.io/otel repository to here. This is based on the package last modified in: 96a5f8f This is related to: https://github.com/open-telemetry/opentelemetry-go/issues/976
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 4, 2020
This is being moved to the contrib repo with open-telemetry/opentelemetry-go-contrib#189 as part of #976.
Taken from the otel repository at 5438916
Aneurysm9
approved these changes
Aug 5, 2020
MrAlias
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Aug 6, 2020
* Remove grpctrace package This is being moved to the contrib repo with open-telemetry/opentelemetry-go-contrib#189 as part of #976. * Update Changelog * Remove the grpc example Moved to contrib repo * Fix spelling error * Update Changelog
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
shbieng
added a commit
to shbieng/opentelemetry-go
that referenced
this pull request
Aug 26, 2022
* Remove grpctrace package This is being moved to the contrib repo with open-telemetry/opentelemetry-go-contrib#189 as part of #976. * Update Changelog * Remove the grpc example Moved to contrib repo * Fix spelling error * Update Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as direct as possible copy of the existing gRPC instrumentation and examples from the OTel repository.
The small changes included are:
go.opentelemetry.io/contrib/google.golang.org/grpcPart of https://github.com/open-telemetry/opentelemetry-go/issues/976
Superseeds #156