Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated exporters #1920

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 16, 2022

No description provided.

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@MrAlias MrAlias mentioned this pull request Mar 16, 2022
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 17, 2022

Merging prior to a full work day as this is a previously communicated change that the community agreed upon.

@MrAlias MrAlias merged commit e4bcc4c into open-telemetry:main Mar 17, 2022
@MrAlias MrAlias deleted the rm-exporters branch March 17, 2022 16:01
@marco-m
Copy link

marco-m commented Mar 17, 2022

@MrAlias it seems that you forgot to update the README; it still contains

[Exporters](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/exporters): Packages providing OpenTelemetry exporters for 3rd-party telemetry systems.

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 17, 2022

@MrAlias it seems that you forgot to update the README; it still contains

[Exporters](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/exporters): Packages providing OpenTelemetry exporters for 3rd-party telemetry systems.

Thanks! I'll include a fix in #1921

@banks
Copy link

banks commented Apr 13, 2022

Hey heads up to say that this broke links in an AWS blog that is still linked from their main feature page under "how to ship metrics to AMP": https://aws.amazon.com/blogs/opensource/building-a-prometheus-remote-write-exporter-for-the-opentelemetry-go-sdk/

Linked here: https://aws.amazon.com/prometheus/features/

To learn more about writing your own client to use remote write, see Building a Prometheus remote write exporter for the OpenTelemetry Go SDK.

No idea if any of the contributors to that blog are likely to see this to help fix that but just wanted to call it out in case others are hunting around! If not I can see if that can be brought up with AWS folks somehow.

I found the deprecation note in the files removed. Repeating here for anyone who might find this and wonder why:

⚠️ This project is deprecated. Use the go.opentelemetry.io/otel/exporters/otlp/otlpmetric exporter as a replacement to send data to a collector which can then export with its PRW exporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants