[Prometheus Remote Write Exporter for Cortex] Add TLS Support and Default HTTP Client #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
August 21, 2020 13:26
ercl
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
MrAlias
reviewed
Aug 25, 2020
MrAlias
reviewed
Aug 25, 2020
added 6 commits
August 26, 2020 03:12
|
Thanks for all the feedback! The recent commits should address everything in the reviews. |
|
@ercl this looks ready to merge. If you can update with the master branch it should be good to go. |
added 2 commits
August 26, 2020 11:28
|
Merged! I also updated the HTTP Transport's DialContext timeout since the mutual tls test was occasionally taking too much time on GOARCH 386. |
Hmm, looks like this is still out of sync. I'll be sure to not merge anything before this if you can update again. |
|
Merged again! I think the reason why CircleCI tests fail is because the testing script sets the timeout at 30s, which the Mutual TLS test occasionally goes over. |
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements TLS support for the Go SDK Prometheus Remote Write Exporter for Cortex. It includes functionality for creating a default HTTP client for the exporter, unit tests, and an integration test for mutual TLS.