mongo: use db.operation instead of resource.name #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
vmihailenco
commented
Sep 11, 2020
| TargetPortKey = label.Key("out.port") | ||
| HTTPMethodKey = label.Key("http.method") | ||
| HTTPCodeKey = label.Key("http.code") | ||
| HTTPURLKey = label.Key("http.url") |
There was a problem hiding this comment.
It looks like HTTP* keys are unused and look out of place (and http.code should be http.status_code). Should I remove them?
There was a problem hiding this comment.
Yes, if they're unused there's no point keeping them around. There should be equivalents in the semconv package anyways.
Aneurysm9
approved these changes
Sep 11, 2020
MrAlias
approved these changes
Sep 11, 2020
|
@MrAlias done |
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
implement #337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec says