Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instrumentation naming #359

Merged
merged 18 commits into from
Sep 24, 2020
Merged

Update instrumentation naming #359

merged 18 commits into from
Sep 24, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 24, 2020 •
edited
Loading

Instrumentation renames:

  • google.golang.org/grpc -> google.golang.org/grpc/otelgrpc
  • go.mongodb.org/mongo-driver -> go.mongodb.org/mongo-driver/mongo/otelmongo
  • net/http -> net/http/otelhttp
  • net/http/httptrace -> net/http/httptrace/otelhttptrace
  • github.com/labstack/echo -> github.com/labstack/echo/otelecho
  • github.com/bradfitz/gomemcache -> github.com/bradfitz/gomemcache/memcache/otelmemcache
  • github.com/gin-gonic/gin -> github.com/gin-gonic/gin/otelgin
  • github.com/gocql/gocql -> github.com/gocql/gocql/otelgocql
  • github.com/emicklei/go-restful -> github.com/emicklei/go-restful/otelrestful
  • github.com/Shopify/sarama -> github.com/Shopify/sarama/otelsarama
  • github.com/gorilla/mux -> github.com/gorilla/mux/otelmux
  • github.com/astaxie/beego -> github.com/astaxie/beego/otelbeego
  • gopkg.in/macaron.v1 -> gopkg.in/macaron.v1/otelmacaron

Superseeds #314
Resolves #164

@MrAlias MrAlias added area: instrumentation Related to an instrumentation package release:required-for-ga labels Sep 24, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 24, 2020
@MrAlias MrAlias self-assigned this Sep 24, 2020
@MrAlias MrAlias added this to In progress in GA Burndown via automation Sep 24, 2020
@MrAlias MrAlias changed the title Update instrumentation namin Update instrumentation naming Sep 24, 2020
GA Burndown automation moved this from In progress to Reviewer approved Sep 24, 2020
XSAM
XSAM approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 24, 2020

Going to merge given this was a discussed change and the large number of files it touches is at high risk for conflicts.

@MrAlias MrAlias merged commit 65f8350 into open-telemetry:master Sep 24, 2020
GA Burndown automation moved this from Reviewer approved to Done Sep 24, 2020
@MrAlias MrAlias deleted the pkg-names branch September 24, 2020 16:06
@MrAlias MrAlias added this to Done in OpenTelemetry Go RC Oct 13, 2020
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@ferhatelmas @rghetia
Drop GO111MODULE environment variable (#359)
921ea03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@XSAM XSAM XSAM approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees

@MrAlias MrAlias

Labels
area: instrumentation Related to an instrumentation package
Projects
No open projects
GA Burndown
  
Done
OpenTelemetry Go RC
  
Done
Milestone
RC1
Development

Successfully merging this pull request may close these issues.

Update instrumentation naming conventions
3 participants
@MrAlias @Aneurysm9 @XSAM