instrgen fixing imports

[pdelewski]

Remove import that only is needed in main.go from the other test data files so it will not fail the build.

[pellared]

How about removing //nolint:all and addressing all the issues? Would it be too much?

[pdelewski]

How about removing //nolint:all and addressing all the issues? Would it be too much?

//nolint:all was added for different reason. Linter is executed at the same time as tests which leads to race conditions and failures

[MrAlias]

Why are these imports removed?

[MrAlias]

It looks like the tests are failing. Can you take a look at the data race?

[pdelewski]

Why are these imports removed?

This import is needed only in main.go, they are leftovers and if you will try to build this test program compiler will complain about unused imports

[pdelewski]

It looks like the tests are failing. Can you take a look at the data race?

They are unrelated to instrgen

[pellared]

How about removing //nolint:all and addressing all the issues? Would it be too much?

//nolint:all was added for different reason. Linter is executed at the same time as tests which leads to race conditions and failures

Then it would be good to add the reason in a comment e.g. like //nolint:all // Linter is executed at the same time as tests which leads to race conditions and failures. Possibly also track it in some issue to resolve it at some point.

[pdelewski]

How about removing //nolint:all and addressing all the issues? Would it be too much?

//nolint:all was added for different reason. Linter is executed at the same time as tests which leads to race conditions and failures

Then it would be good to add the reason in a comment e.g. like //nolint:all // Linter is executed at the same time as tests which leads to race conditions and failures. Possibly also track it in some issue to resolve it at some point.

Good point.