Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(echo): return nil from middleware to handle error only once #377

Merged
merged 2 commits into from
Oct 5, 2020
Merged

fix(echo): return nil from middleware to handle error only once #377

merged 2 commits into from
Oct 5, 2020

Conversation

stanleynguyen
Copy link
Contributor

Resolves #364

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

MrAlias
MrAlias approved these changes Sep 30, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
MrAlias
MrAlias reviewed Sep 30, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit 8244cc7 into open-telemetry:master Oct 5, 2020
@Aneurysm9 Aneurysm9 mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@XSAM XSAM XSAM approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handler triggered twice for echo
4 participants
@stanleynguyen @Aneurysm9 @MrAlias @XSAM