-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce OpenTelemetry events in gRPC interceptor #3964
Merged
pellared
merged 13 commits into
open-telemetry:main
from
mailgun:Baliedge/PIP-2499-reduce-events
Jun 20, 2023
Merged
Reduce OpenTelemetry events in gRPC interceptor #3964
pellared
merged 13 commits into
open-telemetry:main
from
mailgun:Baliedge/PIP-2499-reduce-events
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables `SENT`/`RECEIVED` events in the span.
|
…h the HTTP instrumentation convention.
|
|
|
Baliedge
changed the title
PIP-2499: Reduce OpenTelemetry events
[WIP] PIP-2499: Reduce OpenTelemetry events
Jun 5, 2023
Baliedge
changed the title
[WIP] PIP-2499: Reduce OpenTelemetry events
[WIP] Reduce OpenTelemetry events
Jun 5, 2023
Baliedge
force-pushed
the
Baliedge/PIP-2499-reduce-events
branch
from
June 5, 2023 20:29
c2d5fb7
to
372930d
Compare
Baliedge
changed the title
[WIP] Reduce OpenTelemetry events
[WIP] Reduce OpenTelemetry events in gRPC interceptor
Jun 5, 2023
dmathieu
added
the
blocked: CLA
Waiting on CLA to be signed before progress can be made
label
Jun 6, 2023
Baliedge
changed the title
[WIP] Reduce OpenTelemetry events in gRPC interceptor
Reduce OpenTelemetry events in gRPC interceptor
Jun 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3964 +/- ##
=====================================
Coverage 79.1% 79.2%
=====================================
Files 165 165
Lines 10293 10318 +25
=====================================
+ Hits 8151 8173 +22
- Misses 2006 2008 +2
- Partials 136 137 +1
|
dmathieu
removed
the
blocked: CLA
Waiting on CLA to be signed before progress can be made
label
Jun 8, 2023
dmathieu
reviewed
Jun 8, 2023
instrumentation/google.golang.org/grpc/otelgrpc/test/interceptor_test.go
Outdated
Show resolved
Hide resolved
❤️ Thanks for ur contribution. @Baliedge |
dmathieu
reviewed
Jun 9, 2023
pellared
reviewed
Jun 12, 2023
k8s-publishing-bot
pushed a commit
to kubernetes/api
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/client-go
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/code-generator
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/component-base
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/component-helpers
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kms
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/apiserver
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kube-aggregator
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/sample-apiserver
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/sample-controller
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/metrics
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/cli-runtime
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/sample-cli-plugin
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kube-proxy
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/cri-api
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kubelet
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kube-scheduler
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/controller-manager
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/cloud-provider
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kube-controller-manager
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/cluster-bootstrap
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/csi-translation-lib
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/mount-utils
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/legacy-cloud-providers
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/kubectl
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/pod-security-admission
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/dynamic-resource-allocation
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
k8s-publishing-bot
pushed a commit
to kubernetes/endpointslice
that referenced
this pull request
Apr 24, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964 Kubernetes-commit: 3e5b03eb433ee359782f5aa6e9368ab2a0d0370c
jingczhang
pushed a commit
to nokia/kubernetes
that referenced
this pull request
May 7, 2024
Add otelgrpc.WithMessageEvents(otelgrpc.ReceivedEvents, otelgrpc.SentEvents) to tracing options due to open-telemetry/opentelemetry-go-contrib#3964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RECEIVED
/SENT
events in gRPC spans from interceptors.WithMessageEvents()
option to enable these events.go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
instrumentation.