Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error as a span event #4488

Closed
wants to merge 2 commits into from

Conversation

a-menshchikov
Copy link

This PR adds recording an error info as a span event in a stats handler on stats.End (if an error occured).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: a-menshchikov / name: Alexander Menshchikov (caa5071, c3f6e9e)

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to add the error additionally as an event? Are we missing any information passed (s.Message()) to status description?

I found out that we are usually not getting any valuable data via RecordError.

@a-menshchikov
Copy link
Author

@pellared hi.
While I was looking for an answer to your question, I realized that span tags really have all the same information which contained in the error event. The event timestamp cannot be useful in that case because it points on stats.End moment.

It looks like the PR can be closed.

@pellared
Copy link
Member

Closing. Still thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants