config: add meter/tracer provider config #4617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4617 +/- ##
=======================================
+ Coverage 81.1% 81.3% +0.1%
=======================================
Files 150 150
Lines 10759 11034 +275
=======================================
+ Hits 8731 8975 +244
- Misses 1872 1895 +23
- Partials 156 164 +8
|
codeboten
force-pushed
the
codeboten/implement-tracer-provider-sdk
branch
2 times, most recently
from
7e22836
to
4327828
Compare
added 2 commits
December 18, 2023 14:04
This update includes: - schema_url for resource - without_type_suffix and without_units for prometheus exporter Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Dec 18, 2023
This code will live in the otel-go-contrib `config` package instead. This PR depends on open-telemetry/opentelemetry-go-contrib#4617 Signed-off-by: Alex Boten <aboten@lightstep.com>
added 5 commits
December 19, 2023 11:42
Signed-off-by: Alex Boten <aboten@lightstep.com>
This pulls in the code that was in the collector to configure the MeterProvider and TracerProvider. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/implement-tracer-provider-sdk
branch
from
977e67f
to
5db40c0
Compare
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Dec 21, 2023
This PR is another attempt at filling in the SDK details for NewSDK. It breaks the open-telemetry#4617 per signal to make it more manageable to review. Part of open-telemetry#4371 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 16, 2024
This code will live in the otel-go-contrib `config` package instead. This PR depends on open-telemetry/opentelemetry-go-contrib#4617 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 17, 2024
This code will live in the otel-go-contrib `config` package instead. This PR depends on open-telemetry/opentelemetry-go-contrib#4617 Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the code that was in the collector to configure the MeterProvider and TracerProvider.
Fixes #4371