Add Amazon ECS Resource Detector #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKelvinLo
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
jmacd
approved these changes
Nov 24, 2020
Aneurysm9
approved these changes
Nov 27, 2020
XSAM
approved these changes
Nov 27, 2020
|
@KKelvinLo can you resolve the conflict and ensure this branch is up-to-date with the trunk so we can get it merged? Thanks! |
|
@Aneurysm9 merge conflict should be fixed, cheers! |
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Move dependencies of tools package to a tools directory * remove TOOLS_MOD_DIR from ALL_GO_MOD_DIRS in a Makefile. then run 'go mod tidy' on ALL_GO_MOD_DIRS and TOOLS_MOD_DIR. Co-authored-by: Rahul Patel <rghetia@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Key Functionality
Short description of the changes