Fix module path for AWS ECS resource detector #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccpost
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
XSAM
approved these changes
Jan 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 77.61% 77.61%
=======================================
Files 54 54
Lines 2586 2586
=======================================
Hits 2007 2007
Misses 443 443
Partials 136 136 Continue to review full report at Codecov.
|
dashpole
approved these changes
Jan 11, 2021
Aneurysm9
approved these changes
Jan 11, 2021
Merged
This was referenced Mar 7, 2021
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* fix data race in BatchedSpanProcessor - fixes #517 * fix ci. * fix another test. * move wait group to generateSpan func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading https://aws-otel.github.io/docs/getting-started/go-sdk#using-the-aws-ecs-resource-detector and noticed
go.opentelemetry.io/contrib/detectors/ecsis not go-gettable. This updates the module path to be symmetric with its peers.