Fix datadog incorrect resource names added semconv attribute http.route #5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
dmathieu
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Here, you would be setting http.route as the target, not the route.
The target is /posts/42, while the route is /posts/:id.
If we cannot get the route, it should not be set.
See https://github.com/open-telemetry/semantic-conventions/blob/b77c881ad68dca7bb7af2c97899a0ef64357c47c/docs/http/http-spans.md#http-server-semantic-conventions
| @@ -407,6 +407,7 @@ func (c *httpConv) ServerRequest(server string, req *http.Request) []attribute.K | |||
|
|
|||
| if target != "" { | |||
| attrs = append(attrs, c.HTTPTargetKey.String(target)) | |||
| attrs = append(attrs, c.HTTPTargetKey.String(target)) | |||
There was a problem hiding this comment.
This is using HTTPTargetKey, so it's setting the http.target attribute twice, not http.route.
|
This looks blocked and stale, closing. @MrwanBaghdad if this is in error, please reopen and update/respond to the feedback provided by @dmathieu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
http.routekey in the span attribute to fix Datadog of resource name as it depends onhttp.method+http.route