Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix otelhttptrace example to avoid duplicating the generated data #5564

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Fix otelhttptrace example to avoid duplicating the generated data #5564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
852c34d
fix otelhttptrace example to avoid duplicating the generated data
dmathieu May 13, 2024
8bdd01a
add changelog entry
dmathieu May 13, 2024
3bccf03
switch example to use our own httptrace option
dmathieu May 14, 2024
99488d8
document why we use our own option
dmathieu May 14, 2024
6539287
Merge branch 'main' into otelhttptrace-example-single-tracer
dmathieu May 17, 2024
31e181f
Update instrumentation/net/http/httptrace/otelhttptrace/example/clien…
dmathieu May 30, 2024
000e6ff
Merge branch 'main' into otelhttptrace-example-single-tracer
dmathieu May 30, 2024
8be96e8
Merge branch 'main' into otelhttptrace-example-single-tracer
dmathieu Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The superfluous `response.WriteHeader` call in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` when the response writer is flushed. (#5634)
- Custom attributes targeting metrics recorded by the `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` are not ignored anymore. (#5129)
- Use `c.FullPath()` method to set `http.route` attribute in `go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`. (#5734)
- The double setup in `go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/example` that caused duplicate traces. (#5564)

### Deprecated

Expand All @@ -38,8 +39,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Changed

- Improve performance of `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` with the usage of `WithAttributeSet()` instead of `WithAttribute()`. (#5664)
- Improve performance of `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` with the usage of `WithAttributeSet()` instead of `WithAttribute()`. (#5664)
- Improve performance of `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` with the usage of `WithAttributeSet()` instead of `WithAttribute()`. (#5664)
- Improve performance of `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` with the usage of `WithAttributeSet()` instead of `WithAttribute()`. (#5664)

## [1.27.0/0.52.0/0.21.0/0.7.0/0.2.0] - 2024-05-21

Expand Down
4 changes: 3 additions & 1 deletion instrumentation/net/http/httptrace/otelhttptrace/example/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ func main() {
client := http.Client{
Transport: otelhttp.NewTransport(
http.DefaultTransport,
// By setting the otelhttptrace client in this transport, it can be
// injected into the context after the span is started, which makes the
// httptrace spans children of the transport one.
otelhttp.WithClientTrace(func(ctx context.Context) *httptrace.ClientTrace {
return otelhttptrace.NewClientTrace(ctx)
}),
Expand All @@ -76,7 +79,6 @@ func main() {
ctx, span := tr.Start(ctx, "say hello", trace.WithAttributes(semconv.PeerService("ExampleService")))
defer span.End()

ctx = httptrace.WithClientTrace(ctx, otelhttptrace.NewClientTrace(ctx))
req, _ := http.NewRequestWithContext(ctx, "GET", *url, nil)

fmt.Printf("Sending request...\n")
Expand Down