Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github.com/stretchr/testify from v1.6.1 to v1.7.0 #557

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Upgrade github.com/stretchr/testify from v1.6.1 to v1.7.0 #557

merged 2 commits into from
Jan 20, 2021

Conversation

evantorrie
Copy link
Contributor

Upgrades github/stretchr/testify to 1.7.0 in the following go modules

/propagators/aws
/detectors/aws/eks
/detectors/aws/ecs
/exporters/metric/cortex/utils
/instrumentation/github.com/astaxie/beego/otelbeego
/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo
/instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache
/instrumentation/google.golang.org/grpc/otelgrpc
/instrumentation/net/http/otelhttp
/instrumentation/github.com/Shopify/sarama/otelsarama
/instrumentation/github.com/labstack/echo/otelecho
/instrumentation/github.com/gin-gonic/gin/otelgin
/instrumentation/github.com/gocql/gocql/otelgocql
/instrumentation/gopkg.in/macaron.v1/otelmacaron
/instrumentation/github.com/emicklei/go-restful/otelrestful
/instrumentation/host
/instrumentation/github.com/gorilla/mux/otelmux
/instrumentation/net/http/httptrace/otelhttptrace
/propagators
/exporters/metric/cortex
/detectors/aws

@evantorrie
Copy link
Contributor Author

evantorrie commented Jan 19, 2021 •
edited

Closes #554 Closes #551 Closes #550 Closes #549 Closes #548 Closes #547 Closes #546 Closes #544 Closes #542 Closes #541 Closes #540 Closes #539 Closes #538 Closes #537 Closes #536 Closes #535 Closes #534 Closes #533 Closes #532 Closes #529 Closes #527

@evantorrie evantorrie added Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG dependencies Pull requests that update a dependency file go Pull requests that update Go code and removed dependencies Pull requests that update a dependency file labels Jan 19, 2021
@Aneurysm9 Aneurysm9 merged commit 3d7fac5 into open-telemetry:master Jan 20, 2021
This was referenced Jan 20, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 20, 2021
Closed
Closed
Closed
Closed
@evantorrie evantorrie deleted the testify-update branch January 20, 2021 17:48
@MrAlias MrAlias mentioned this pull request Feb 15, 2021
Merged
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@evantorrie
Replace ErrNoLastValue and ErrEmptyDataSet by ErrNoData (#557)
217a97d 
Handle ForEach returning an error
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@oncilla @rghetia
prometheus: check return value from CheckpointSet.ForEach (#622)
6005d01 
This PR modifies prometheus.Collect to reflect the change introduced
by #557.

The `export{Counter,Histogram,LastValue,Summary}` methods now all return
an error instead of calling the error callback directly.
The callback is now only called on the returned error from `ForEach`.

fixes #563

Co-authored-by: Rahul Patel <rahulpa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@MrAlias MrAlias Awaiting requested review from MrAlias

@XSAM XSAM Awaiting requested review from XSAM

Assignees
No one assigned
Labels
go Pull requests that update Go code Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evantorrie @Aneurysm9