otelzap: Implement methods on objectEncoder #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushijain21
changed the title
pellared
reviewed
May 16, 2024
Yes. But I suggest implementing just the simple methods and leaving the complex ones for separate PRs. |
pellared
added
the
Skip Changelog
pellared
reviewed
May 16, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5595 +/- ##
=======================================
+ Coverage 63.0% 63.1% +0.1%
=======================================
Files 194 194
Lines 11949 11956 +7
=======================================
+ Hits 7534 7556 +22
+ Misses 4198 4183 -15
Partials 217 217
|
khushijain21
commented
May 16, 2024
pellared
approved these changes
May 16, 2024
dmathieu
reviewed
May 16, 2024
XSAM
approved these changes
May 16, 2024
dmathieu
approved these changes
May 17, 2024
zailic
pushed a commit
to zailic/opentelemetry-go-contrib
that referenced
this pull request
May 20, 2024
Part of open-telemetry#5191 --------- Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5191
Pre-work #5279
This PR implements
AddBinaryAddByteStringandAddBoolmethod onobjectEncoderP.S will some more methods be accepted in this PR?