Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelzap: Implement namespace method #5721

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Jun 4, 2024

Part of #5191

Pre-work #5279

The approach is to use linked list to open a namespace and keep track of it.
calculate method iterates to the most nested namespace and appends data in reverse order.

@khushijain21 khushijain21 requested review from pellared and a team as code owners June 4, 2024 10:11
@khushijain21 khushijain21 changed the title otelzap: Implement namespace method [WIP] otelzap: Implement namespace method Jun 5, 2024
@khushijain21 khushijain21 changed the title [WIP] otelzap: Implement namespace method otelzap: Implement namespace method Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.5%. Comparing base (c7fb822) to head (340b6e6).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5721   +/-   ##
=====================================
  Coverage   64.4%   64.5%           
=====================================
  Files        200     200           
  Lines      12540   12557   +17     
=====================================
+ Hits        8084    8100   +16     
  Misses      4220    4220           
- Partials     236     237    +1     
Files Coverage Δ
bridges/otelzap/core.go 89.8% <100.0%> (+0.1%) ⬆️
bridges/otelzap/encoder.go 85.8% <100.0%> (+2.0%) ⬆️

... and 1 file with indirect coverage changes

@pellared
Copy link
Member

build_and_test / lint (pull_request) is failing. Can you fix it before I make a review?

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jun 18, 2024
bridges/otelzap/encoder.go Outdated Show resolved Hide resolved
bridges/otelzap/encoder.go Outdated Show resolved Hide resolved
bridges/otelzap/encoder.go Outdated Show resolved Hide resolved
khushijain21 and others added 5 commits June 18, 2024 17:56
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@pellared pellared merged commit 48f7f61 into open-telemetry:main Jun 19, 2024
24 checks passed
@MrAlias MrAlias added this to the v1.28.0 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants