HTTP Semconv migration Part1 Client - v1.24.0 support #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nventions in http client attributes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5773 +/- ##
=====================================
Coverage 64.4% 64.4%
=====================================
Files 200 200
Lines 12540 12557 +17
=====================================
+ Hits 8082 8095 +13
- Misses 4221 4223 +2
- Partials 237 239 +2
|
MadVikingGod
added
the
Skip Changelog
2 tasks
MrAlias
reviewed
Jun 26, 2024
Comment on lines
+105
to
+113
| func (c HTTPClient) Status(code int) (codes.Code, string) { | ||
| if code < 100 || code >= 600 { | ||
| return codes.Error, fmt.Sprintf("Invalid HTTP status code %d", code) | ||
| } | ||
| if code >= 400 { | ||
| return codes.Error, "" | ||
| } | ||
| return codes.Unset, "" | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the new semantic version (v1.24.0) attribute producer to the semconv of otlehttp.
Part of #5332