Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open telemetry severity hook integration for zerolog #5782

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AkhigbeEromo
Copy link

This PR introduces the otelzerolog package, which provides a SeverityHook to bridge the logging capabilities of Zerolog with OpenTelemetry. The following key features are included:

Changes

  • Added config struct to handle configuration options.
  • Implemented Option interface and related functions (WithVersion, WithSchemaURL, WithLoggerProvider).
  • Created NewSeverityHook function to initialize a SeverityHook.
  • Defined SeverityHook struct to perform the logging bridge functionality.

Part of #5405

@AkhigbeEromo AkhigbeEromo requested a review from a team as a code owner June 18, 2024 22:49
@AkhigbeEromo
Copy link
Author

Hello @MrAlias, hope this is okay for a start

@AkhigbeEromo
Copy link
Author

Also, do i need to make a changelog for each of the PRs concerning the zerolog bridge

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend splitting this even more, with a PR that sets up the boilerplate structs/interfaces that will be used in the end, without their implementations.

Much like what was done in #5449

@AkhigbeEromo
Copy link
Author

Thank you @dmathieu, I know what to do now.

I will split up and send in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants