-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping otel version to v0.18.0. Prepare for releasing v0.18.0 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
March 4, 2021 22:26
Codecov Report
@@ Coverage Diff @@
## main #600 +/- ##
=======================================
- Coverage 77.9% 77.9% -0.1%
=======================================
Files 55 55
Lines 2602 2611 +9
=======================================
+ Hits 2029 2035 +6
- Misses 443 446 +3
Partials 130 130
|
MrAlias
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇!
instrumentation/github.com/Shopify/sarama/otelsarama/message.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/Shopify/sarama/otelsarama/message.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/emicklei/go-restful/otelrestful/example/server.go
Show resolved
Hide resolved
MrAlias
approved these changes
Mar 5, 2021
This was referenced Mar 7, 2021
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
otelmemcache
no longer sets span status to OK instead of leaving it unset. (otelmemcache: Simplify config and span status setting #477)StreamClientInterceptor
(Fix goroutine leak in gRPC StreamClientInterceptor #581)Removed
otelmemcache
configuration and span attributes. (otelmemcache: Simplify config and span status setting #477)