Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .gitattributes #777

Merged
merged 2 commits into from
May 13, 2021
Merged

Create .gitattributes #777

merged 2 commits into from
May 13, 2021

Conversation

pellared
Copy link
Member

Why

Get rid of false negatives on Windows like:

File is not `gofmt`-ed with `-s` (gofmt)

Also, it helps to work on Windows in native, WSL and Development Container modes on the same repository.

What

Add .gitattributes so that most files (especially *.sh ,*.go, Makefile) use LF and only Windows-specific have CLRF line ending.

Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking whether the last character was dropped?

.gitattributes Outdated Show resolved Hide resolved
@pellared pellared requested a review from evantorrie May 13, 2021 18:01
@MrAlias MrAlias merged commit 20c1c5d into open-telemetry:main May 13, 2021
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
Add gRPC Default Service Config To OTLP Exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants