Added option to using a skipper in the echo otel middleware #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcairns
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
|
|
|
@pcairns I think you may need to rebase this to eliminate commit |
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
=====================================
Coverage 75.4% 75.4%
=====================================
Files 69 69
Lines 3064 3071 +7
=====================================
+ Hits 2311 2318 +7
Misses 613 613
Partials 140 140
|
pcairns
force-pushed
the
add-skipper-to-echo-middleware
branch
from
ad1634a
to
aea42e9
Compare
|
@Aneurysm9 sorry I've been away on vacation, this should be rebased now |
pellared
approved these changes
Jul 15, 2021
|
I've updated the tests to include a check for the status code |
pellared
approved these changes
Jul 16, 2021
Aneurysm9
approved these changes
Jul 23, 2021
Aneurysm9
reviewed
Jul 23, 2021
garrettwegan
referenced
this pull request
in garrettwegan/opentelemetry-go-contrib
Jul 28, 2021
* Added option to using a skipper in the echo otel middleware * check status code in tests * fix option interface use Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for a skipper (https://github.com/labstack/echo/blob/master/middleware/middleware.go#L15) to be passed into the echo middleware. The use case for this is we would like the ability to bypass tracing for certain routes (eg. health check endpoints).