gRPC: fix goroutine leak if client stream CloseSend is not called. #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outside of a unidirectional Client->Server stream there's no requirement that CloseSend must be called (and it doesn't make much sense for a Server->Client stream). If CloseSend is not called, the RPC span will not be ended and a goroutine will be leaked. We saw a large number of goroutines leaked when we enabled gRPC instrumentation in our service. Someone else has also reported this issue here: open-telemetry#818
vadimberezniker
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
=======================================
- Coverage 79.4% 79.1% -0.4%
=======================================
Files 62 62
Lines 2755 2748 -7
=======================================
- Hits 2188 2174 -14
- Misses 437 443 +6
- Partials 130 131 +1
|
Aneurysm9
approved these changes
Jun 30, 2021
|
Friendly ping :) |
coryb
reviewed
Jul 7, 2021
tonistiigi
approved these changes
Jul 9, 2021
|
Ping. This PR has been open for 2 weeks now. |
|
Thank you! Any blockers for merging this? |
|
What's left? |
MrAlias
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outside of a unidirectional Client->Server stream there's no requirement
that CloseSend must be called (and it doesn't make much sense for a
Server->Client stream).
If CloseSend is not called, the RPC span will not be ended and a
goroutine will be leaked.
We saw a large number of goroutines leaked when we enabled gRPC
instrumentation in our service.
Resolves #818