Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelbeego: Refactor option type #853

Merged
merged 3 commits into from
Jul 9, 2021
Merged

otelbeego: Refactor option type #853

merged 3 commits into from
Jul 9, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 6, 2021

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #853 (94fc769) into main (01fdab7) will increase coverage by 0.6%.
The diff coverage is 82.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #853     +/-   ##
=======================================
+ Coverage   78.4%   79.0%   +0.6%     
=======================================
  Files         62      62             
  Lines       2737    2731      -6     
=======================================
+ Hits        2146    2159     +13     
+ Misses       456     440     -16     
+ Partials     135     132      -3     
Impacted Files Coverage Δ
detectors/gcp/gce.go 7.3% <0.0%> (ø)
detectors/gcp/gke.go 0.0% <0.0%> (ø)
exporters/metric/dogstatsd/internal/statsd/conn.go 59.2% <ø> (ø)
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 100.0% <ø> (ø)
...ion/github.com/aws/aws-sdk-go-v2/otelaws/config.go 100.0% <ø> (ø)
instrumentation/host/host.go 73.1% <ø> (ø)
...umentation/net/http/httptrace/otelhttptrace/api.go 100.0% <ø> (ø)
...on/net/http/httptrace/otelhttptrace/clienttrace.go 76.2% <ø> (ø)
instrumentation/net/http/otelhttp/labeler.go 84.6% <ø> (ø)
detectors/aws/eks/detector.go 32.7% <33.3%> (+3.6%) ⬆️
... and 24 more

@MrAlias MrAlias merged commit cfed0ec into open-telemetry:main Jul 9, 2021
@pellared pellared deleted the otelbeego-refactor-option branch July 10, 2021 05:33
garrettwegan referenced this pull request in garrettwegan/opentelemetry-go-contrib Jul 13, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
garrettwegan referenced this pull request in garrettwegan/opentelemetry-go-contrib Jul 22, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants