otelhttptrace: get tracer from request if available #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
Marking as draft so changelog can be updated after #873 merge . If I do it now it will cause a conflict. |
|
@tonistiigi #873 was merged; guess this needs to be rebased and moved out of draft |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
otelhttptrace-context
branch
from
dd7efee
to
ef806f3
Compare
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
=====================================
Coverage 69.3% 69.3%
=====================================
Files 127 127
Lines 5474 5479 +5
=====================================
+ Hits 3794 3799 +5
Misses 1533 1533
Partials 147 147
|
pellared
approved these changes
Nov 3, 2021
|
@XSAM @Aneurysm9 this one LGTY? |
XSAM
approved these changes
Nov 4, 2021
MadVikingGod
approved these changes
Nov 8, 2021
|
@pellared @XSAM @MadVikingGod Is there a blocker to merge this one? Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar change as #873 for
otelhttptrace. Picks up the correctTracingProviderbased on parent span in the config.@Aneurysm9
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com