Using latest version of mod-tidier which supports go.{mod,sum} check #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As go mod tidy does have occasion to change `go.mod` files in addition to `go.sum` (e.g. when a transitive dependency changes from an implicit to explicit dependency), this new flag (`gomodsum_only`) allows the build to pass so long as the only files changed are either `go.mod` or `go.sum`
evantorrie
requested review from
Aneurysm9,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod tidydoes have occasion to changego.modfiles in addition togo.sum(e.g. when a transitive dependency changes from an implicit to explicit dependency).The latest beta of the mott-the-tidier action provides a new flag (
gomodsum_only) which defaults to true, and allows the build to pass so long as the only files changed are eithergo.modorgo.sum.The action is still restricted to running only on pull requests at the time a
dependencieslabel is added to the PR.