-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS X-Ray config module for Lambda instrumentation #984
Conversation
@Aneurysm9 @MrAlias @dashpole @punya Feel free to take a look on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm with just a few small comments!
instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/README.md
Outdated
Show resolved
Hide resolved
} | ||
``` | ||
|
||
Now configure the instrumentation with the provided options to export traces to AWS X-Ray via [the OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector) running as a Lambda Extension. Instructions for running the OTel Collector as a Lambda Extension can be found in the [AWS OpenTelemetry Documentation](https://aws-otel.github.io/docs/getting-started/lambda). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a suggestion.
instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/xrayconfig.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/xrayconfig.go
Outdated
Show resolved
Hide resolved
@Aneurysm9 addressed your comments! |
@MrAlias Could you take a quick look at this PR if you have a chance? |
This test needs to be fixed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the test failure is fixed, this looks good to me.
instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/xrayconfig_test.go
Outdated
Show resolved
Hide resolved
(assuming the above suggestions are resolved!) |
@dashpole @Aneurysm9 can you please re-review? |
Thanks! @jmacd @dashpole @Aneurysm9 |
Draft as waiting on merge of #882 . Currently based off #882 source so will require a quick rebase before being opened as full PR.
Changes not included in #882 are found in commit eef81a9 and later