Skip to content

Commit

Permalink
Add ModPath field to structfield.ID (#450)
Browse files Browse the repository at this point in the history
* Add ModPath field to structfield.ID

Track the module containing the package the struct is within. This is
used in the offsets to scope a version correctly.

* Add change to changelog
  • Loading branch information
MrAlias committed Nov 2, 2023
1 parent 647063c commit 217fd6e
Show file tree
Hide file tree
Showing 16 changed files with 2,935 additions and 3,135 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ OpenTelemetry Go Automatic Instrumentation adheres to [Semantic Versioning](http

- Parse Go versions that contain `GOEXPERIMENT` suffixes. ([#389](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/389))
- Include the schema URL for the semantic convention used in the exported resource. ([#426](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/426))
- Support Go module `replace` directives for the `golang.org/x/net` within the `google.golang.org/grpc` server instrumentation. ([#450](https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/450))

### Removed

Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/inject/consts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func TestWithOffset(t *testing.T) {
require.NoError(t, err)

const off uint64 = 1
id := structfield.NewID("net/http", "Request", "Method")
id := structfield.NewID("std", "net/http", "Request", "Method")

origOff := offsets
t.Cleanup(func() { offsets = origOff })
Expand Down
Loading

0 comments on commit 217fd6e

Please sign in to comment.