Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModPath field to structfield.ID #450

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 1, 2023

Fix #449

Track the module containing the package the struct is within. This is used in the offsets to scope a version correctly.

  • Add a ModPath field to structfield.ID
  • Support modules in the structfield.Index JSON marshal/unmarshal operations
  • Regenerate offsets to contain golang.org/x/net versions
  • Update the gRPC server instrumentation to reference the golang.org/x/net version

Track the module containing the package the struct is within. This is
used in the offsets to scope a version correctly.
@MrAlias MrAlias marked this pull request as ready for review November 1, 2023 21:14
@MrAlias MrAlias requested a review from a team as a code owner November 1, 2023 21:14
@pellared

This comment was marked as outdated.

@MrAlias MrAlias merged commit 217fd6e into open-telemetry:main Nov 2, 2023
13 checks passed
@MrAlias MrAlias deleted the structfield-mod branch November 2, 2023 18:27
@MrAlias MrAlias added this to the v0.8.0-alpha milestone Nov 2, 2023
@MrAlias MrAlias mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offsets are not always tied to the module version containing the offset
2 participants