Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module structure #304

Merged
merged 16 commits into from
Sep 18, 2023
Merged

Fix module structure #304

merged 16 commits into from
Sep 18, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 13, 2023

  • Remove internal/test modules
    • These modules have not been released yet
    • They do not need to be distinct from the top-level module given this project is not meant to be a library and the number of dependencies is not a concern
  • Unify all examples into a single module
    • The httpPlusdb example has not been released yet, remove the go.mod in that directory
    • Deprecate rolldice to have it moved to the new examples module
  • Fix the versions file
    • Fix the soon-to-be-removed test/e2e/databasesql module name and ignore it in versions.yaml
    • Add the examples module

@MrAlias MrAlias marked this pull request as ready for review September 13, 2023 16:12
@MrAlias MrAlias requested a review from a team as a code owner September 13, 2023 16:12
@MrAlias MrAlias added this to the v0.4.0-alpha milestone Sep 13, 2023
@MrAlias MrAlias marked this pull request as draft September 13, 2023 16:35
@MrAlias

This comment was marked as outdated.

Sign in to view
@MrAlias MrAlias marked this pull request as ready for review September 14, 2023 16:55
dineshg13
dineshg13 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pellared
pellared approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrAlias MrAlias merged commit 6819c56 into open-telemetry:main Sep 18, 2023
13 checks passed
@MrAlias MrAlias deleted the rm-internal-mod branch September 18, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dineshg13 dineshg13 dineshg13 approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrAlias @dineshg13 @pellared