-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTTP server ebpf - add status code #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
changed the title
Update server http bpf - add status code (WIP)
Update server http ebpf - add status code (WIP)
Oct 28, 2023
RonFed
changed the title
Update server http ebpf - add status code (WIP)
Update server http ebpf - add status code
Oct 29, 2023
RonFed
changed the title
Update server http ebpf - add status code
Update HTTP server ebpf - add status code
Oct 29, 2023
edeNFed
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
pellared
approved these changes
Oct 30, 2023
pellared
added a commit
to pellared/opentelemetry-go-instrumentation
that referenced
this pull request
Oct 30, 2023
MrAlias
pushed a commit
that referenced
this pull request
Oct 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to prepare an easier way to collect HTTP server related fields by eBPF.
net/http.(*response)
struct at the entry probe.net/http.response
struct to the offsets being tracked (currently thereq
andstatus
fields of that struct are being tracked, and we'll add more in the future to support more attributes).