Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease v0.11.0-alpha #737

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Prerelease v0.11.0-alpha #737

merged 9 commits into from
Mar 28, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Mar 26, 2024

Added

  • Test build using Go 1.22. (Support and test Go 1.22 #672)
  • Base Dockerfile and build caching (#683)
  • Add server.address, server.port and network.protocol.version to HTTP client spans (#696)
  • Update http server attributes to latest semantic conventions (#708)

Fixed

  • Don't call manager.Close() when Analyze() fails. (#638)
  • Close proc file when done discovering PID. (#649)
  • Use debug packages to parse Go and modules' versions. (#653)
  • Clean up warn in otelglobal SetStatus() when grabbing the status code. (#675)
  • Reset proc offset after a failed iteration. (#681)
  • Avoid using runtime.NumCPU to get the number of CPUs on the system before remote mmap (#680)
  • Cleanup eBPF maps only when we stop using the memory (#682)

@damemi damemi requested a review from a team as a code owner March 26, 2024 17:03
@damemi
Copy link
Contributor Author

damemi commented Mar 26, 2024

@MrAlias I had to manually update version.go, is make prerelease supposed to do that?

@RonFed
Copy link
Contributor

RonFed commented Mar 26, 2024

Hi @damemi, I have a small bug fix I wish to get merged before this release, I will open a PR in the next hour or so.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2024

@MrAlias I had to manually update version.go, is make prerelease supposed to do that?

No, you did it correctly. That is a manual process given it is not always clear what version you are bumping to for each modset.

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2024

You'll need to update the test results as well to match the new version.

damemi and others added 2 commits March 26, 2024 14:34
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@damemi
Copy link
Contributor Author

damemi commented Mar 27, 2024

@MrAlias should be good now, btw I opened #739 to make generating the fixtures a little easier. Links check is going to fail without the new tag.

Should I wait for #738 and add that to the changelog?

@MrAlias
Copy link
Contributor

MrAlias commented Mar 28, 2024

Should I wait for #738 and add that to the changelog?

Yes, please. It should be merged now.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 28, 2024

Links check is going to fail without the new tag.

Yep, this is the norm 😄

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the v0.11.0-alpha milestone Mar 28, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Mar 28, 2024

Should I wait for #738 and add that to the changelog?

Yes, please. It should be merged now.

Looks like the changelog still needs to be updated.

We should turn on enforcement of the changelog addition that we have in other repos ...

damemi and others added 2 commits March 28, 2024 14:58
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@damemi
Copy link
Contributor Author

damemi commented Mar 28, 2024

@MrAlias updated with a changelog entry for #738 this should be good now

@MrAlias MrAlias merged commit 53b7621 into open-telemetry:main Mar 28, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants