Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate e2e fixture generation and validation #739

Open
damemi opened this issue Mar 27, 2024 · 0 comments
Open

Separate e2e fixture generation and validation #739

damemi opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@damemi
Copy link
Contributor

damemi commented Mar 27, 2024

The make fixture commands currently generate and validate the fixtures in the same command. These should be separated into distinct commands (eg, make fixtures and make verify-fixtures)

It's necessary for us to regularly regenerate the fixtures (such as in a new release or when adding a new library). However the bats check that is currently combined with generation does a git diff to make sure no code changes have broken the e2e.

That's what it should do, but when it's combined with the step to regenerate fixtures, it means it will always fail. This means that the kind cluster is never deleted and makes it difficult to regenerate all fixtures at once.

Also, we should have a single command to generate all fixtures.

Related issue to refine e2e tests altogether: #93

@damemi damemi added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant